Closed Bug 1622690 Opened 5 years ago Closed 2 years ago

testing/geckodriver/: Fix the clippy warnings

Categories

(Developer Infrastructure :: Lint and Formatting, task)

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1807248

People

(Reporter: Sylvestre, Unassigned, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=rust])

Filling as a good first bug to learn workflows.

As the change is easy, it is mostly to learn how to contribute to Firefox.

To run the linter:
$ ./mach lint -l clippy testing/geckodriver/ --warnings

Warnings:

xxx/testing/geckodriver/build.rs
  45:12  warning  this `else { if .. }` block can be collapsed  clippy::collapsible_if (clippy)

xxx/testing/geckodriver/src/main.rs
   318:85  warning  redundant clone                 clippy::redundant_clone (clippy)
   481:53  warning  redundant clone                 clippy::redundant_clone (clippy)
   860:47  warning  redundant clone                 clippy::redundant_clone (clippy)
   933:38  warning  redundant clone                 clippy::redundant_clone (clippy)
   955:41  warning  redundant clone                 clippy::redundant_clone (clippy)
   965:41  warning  redundant clone                 clippy::redundant_clone (clippy)
  1677:61  warning  using `clone` on a `Copy` type  clippy::clone_on_copy (clippy)

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Product: Firefox Build System → Developer Infrastructure
Severity: normal → S3

It looks like this has been fixed as part of bug 1807248.

$ ./mach lint -l clippy testing/geckodriver/ --warnings
✖ 0 problems (0 errors, 0 warnings, 0 fixed)
Status: NEW → RESOLVED
Closed: 2 years ago
Duplicate of bug: 1807248
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.